Add new timestamp format: %z %Y-%m-%d %H:%M:%S.%3 #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirkrodrigues
requested changes
Jun 13, 2024
| @@ -182,6 +182,8 @@ void TimestampPattern::init() { | |||
| patterns.emplace_back(4, "%a %b %e %H:%M:%S %Y"); | |||
| // E.g. Sun Jan 1 15:50:45 2015 | |||
| patterns.emplace_back(0, "%a %b %e %H:%M:%S %Y"); | |||
| // E.g. +0800 1970-01-01 08:00:00.235 | |||
| patterns.emplace_back(0, "%z %Y-%m-%d %H:%M:%S.%3"); | |||
There was a problem hiding this comment.
%zis not a supported format specifier. You're probably thinking of a change that hasn't yet been fully merged. @LinZhihao-723 was working on it but he has other priorities at present.- We should also add a unit test for any new timestamp pattern we add.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new timestamp format:
%z %Y-%m-%d %H:%M:%S.%3Sample timestamp string:
+0800 1970-01-01 08:00:00.235